Skip to content

[REBASE&FF] .azurepipelines: Add CLANGPDB CI#896

Merged
makubacki merged 4 commits into
release/202511from
personal/joeyvagedes/clangpdb
Jun 17, 2026
Merged

[REBASE&FF] .azurepipelines: Add CLANGPDB CI#896
makubacki merged 4 commits into
release/202511from
personal/joeyvagedes/clangpdb

Conversation

@Javagedes

Copy link
Copy Markdown
Contributor

Description

Add CI that specifically builds each package in DEBUG and RELEASE with CLANGPDB on both Windows and Linux. Applies necessary changes to compile all packages with CLANGPDB.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Windows: https://dev.azure.com/projectmu/mu/_build/results?buildId=111589&view=results
Linux: https://dev.azure.com/projectmu/mu/_build/results?buildId=111590&view=results

Integration Instructions

N/A

@mu-automation

mu-automation Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

❌ QEMU Validation Failed

Source Dependencies

Repository Commit
mu_plus 71c46c7
mu_tiano_platforms 877ea2f

Results

Platform Target Build Boot Overall Boot Time Build Logs Boot Logs
Q35 DEBUG ✅ success ✅ success 0m 20s Build Logs Boot Logs
ArmVirt DEBUG ✅ success ❌ failure 5m 0s (timed out) Build Logs Boot Logs

Workflow run: https://github.com/microsoft/mu_plus/actions/runs/27702808583

This comment was automatically generated by the Mu QEMU PR Validation workflow.

@mu-automation mu-automation Bot added the impact:non-functional Does not have a functional impact label Jun 15, 2026
@Javagedes Javagedes linked an issue Jun 15, 2026 that may be closed by this pull request
1 task
@codecov-commenter

codecov-commenter commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/202511@74955ad). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202511     #896   +/-   ##
=================================================
  Coverage                  ?   10.23%           
=================================================
  Files                     ?      149           
  Lines                     ?    24522           
  Branches                  ?     2346           
=================================================
  Hits                      ?     2509           
  Misses                    ?    21977           
  Partials                  ?       36           
Flag Coverage Δ
AdvLoggerPkg 3.07% <ø> (?)
HidPkg 2.79% <ø> (?)
MfciPkg 34.00% <ø> (?)
MsCorePkg 1.30% <ø> (?)
MsWheaPkg 7.37% <ø> (?)
XmlSupportPkg 25.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .azurepipelines/Windows-CLANGPDB.yml
@Javagedes Javagedes force-pushed the personal/joeyvagedes/clangpdb branch 3 times, most recently from 9a0c0fb to d3f5cf2 Compare June 15, 2026 21:42
@makubacki

Copy link
Copy Markdown
Member

@Javagedes, is the PR ready for review now?

@Javagedes

Copy link
Copy Markdown
Contributor Author

@Javagedes, is the PR ready for review now?

Yes

@os-d os-d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t actually fix the reported error; did that not repro or are we not building the lib in CI?

@makubacki

Copy link
Copy Markdown
Member

@Javagedes, this commit message has a typo that makes it difficult to read:

Any if the error handling conditions that cause a
goto Done will call if (Blt != NULL) even
though Blt may not have been initialized. This
commit sets Blt to null at the beggining of the
function to resolve this.

If you could, please fix that before merging.

Any io the error handling conditions that cause a
goto `Done` will call `if (Blt != NULL)` even
though Blt may not have been initialized. This
commit sets Blt to null at the beggining of the
function to resolve this.
This commit adds the CONST qualifier to the CHAR8
strings to prevent memcpy from being used to copy the strings around.
Specify CLANGPDB build flags so that GCC build flags are not applied to
the CLANGPDB build
@makubacki makubacki force-pushed the personal/joeyvagedes/clangpdb branch from d3f5cf2 to 71c46c7 Compare June 17, 2026 15:59
@makubacki

makubacki commented Jun 17, 2026

Copy link
Copy Markdown
Member

If you could, please fix that before merging.

Since @Javagedes is unavailable at the moment, I made that update. Given the pipeline files look reasonable and it would be beneficial to start getting coverage, I am merging the PR now.

@makubacki makubacki enabled auto-merge (rebase) June 17, 2026 16:07
@makubacki makubacki merged commit 999f443 into release/202511 Jun 17, 2026
31 of 42 checks passed
@makubacki makubacki deleted the personal/joeyvagedes/clangpdb branch June 17, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unremoved deprecated code in MemoryProtectionExceptionHandlerLib

6 participants