Skip to content

MsCorePkg: Remove the non-existent header files in aarch64#899

Merged
os-d merged 1 commit into
microsoft:release/202511from
qaz6750:release/202511
Jun 17, 2026
Merged

MsCorePkg: Remove the non-existent header files in aarch64#899
os-d merged 1 commit into
microsoft:release/202511from
qaz6750:release/202511

Conversation

@qaz6750

@qaz6750 qaz6750 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Description

As stated in #895, this header file no longer exists, and the issue has been fixed in X64. However, Aarch64 was overlooked, so it should be applied to AArch64 as well.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

N/A

Integration Instructions

N/A

Co-authored-by: Kancy Joe <kancy2333@outlook.com>
Signed-off-by: XiaoYeZi <2838632319@qq.com>
Copilot AI review requested due to automatic review settings June 17, 2026 12:26
@mu-automation

mu-automation Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

❌ QEMU Validation Failed

Source Dependencies

Repository Commit
mu_plus 74a9c87
mu_tiano_platforms 877ea2f

Results

Platform Target Build Boot Overall Boot Time Build Logs Boot Logs
Q35 DEBUG ✅ success ❌ failure 5m 0s (timed out) Build Logs Boot Logs
ArmVirt DEBUG ✅ success ✅ success 0m 14s Build Logs Boot Logs

Workflow run: https://github.com/microsoft/mu_plus/actions/runs/27690530666

This comment was automatically generated by the Mu QEMU PR Validation workflow.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Removes an unused protocol header include from the AArch64 memory protection exception handler library to simplify dependencies.

Changes:

  • Dropped Protocol/MemoryProtectionNonstopMode.h include from MemoryProtectionExceptionHandlerLibAArch64.c

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mu-automation mu-automation Bot added the impact:non-functional Does not have a functional impact label Jun 17, 2026
@codecov-commenter

codecov-commenter commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/202511@6dca0d3). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/202511    #899   +/-   ##
================================================
  Coverage                  ?   1.30%           
================================================
  Files                     ?      56           
  Lines                     ?    6902           
  Branches                  ?      51           
================================================
  Hits                      ?      90           
  Misses                    ?    6812           
  Partials                  ?       0           
Flag Coverage Δ
MsCorePkg 1.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@makubacki makubacki added the type:bug Something isn't working label Jun 17, 2026
@makubacki makubacki requested a review from os-d June 17, 2026 12:47
@os-d os-d merged commit 038be70 into microsoft:release/202511 Jun 17, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants