Skip to content

MsCorePkg: Fix double components specifier for AARCH64#901

Merged
makubacki merged 1 commit into
microsoft:release/202511from
makubacki:fix_double_components_aarch64
Jun 17, 2026
Merged

MsCorePkg: Fix double components specifier for AARCH64#901
makubacki merged 1 commit into
microsoft:release/202511from
makubacki:fix_double_components_aarch64

Conversation

@makubacki

Copy link
Copy Markdown
Member

Description

[Components.AARCH64, Components.AARCH64] should just be [Components.AARCH64] in MsCorePkg.dsc.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

  • Local MsCorePkg CI build

Integration Instructions

  • N/A

@makubacki makubacki requested review from os-d and vineelko June 17, 2026 16:13
@makubacki makubacki self-assigned this Jun 17, 2026
@mu-automation

mu-automation Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

✅ QEMU Validation Passed

Source Dependencies

Repository Commit
mu_plus 2d114e7
mu_tiano_platforms 877ea2f

Results

Platform Target Build Boot Overall Boot Time Build Logs Boot Logs
Q35 DEBUG ✅ success ✅ success 0m 18s Build Logs Boot Logs
ArmVirt DEBUG ✅ success ✅ success 0m 14s Build Logs Boot Logs

Workflow run: https://github.com/microsoft/mu_plus/actions/runs/27706760995

This comment was automatically generated by the Mu QEMU PR Validation workflow.

@mu-automation mu-automation Bot added the impact:non-functional Does not have a functional impact label Jun 17, 2026
@makubacki makubacki added the type:bug Something isn't working label Jun 17, 2026
@codecov-commenter

codecov-commenter commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/202511@999f443). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/202511    #901   +/-   ##
================================================
  Coverage                  ?   1.30%           
================================================
  Files                     ?      56           
  Lines                     ?    6902           
  Branches                  ?      51           
================================================
  Hits                      ?      90           
  Misses                    ?    6812           
  Partials                  ?       0           
Flag Coverage Δ
MsCorePkg 1.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

`[Components.AARCH64, Components.AARCH64]` should just be
`[Components.AARCH64]` in `MsCorePkg.dsc`.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki force-pushed the fix_double_components_aarch64 branch from 60ff430 to 2d114e7 Compare June 17, 2026 17:06
@makubacki makubacki enabled auto-merge (squash) June 17, 2026 17:06
@makubacki makubacki merged commit d2b8412 into microsoft:release/202511 Jun 17, 2026
34 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants