[sklearn]: use npt.NDArray instead of np.ndarray#388
Open
hoel-bagard wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Pull request overview
Updates scikit-learn stubs to prefer a numpy.typing-based array type (npt.NDArray[Any]) over np.ndarray, aiming to reduce Pyright reportUnknownMemberType noise and make array typing more consistent across the sklearn stubs.
Changes:
- Added a shared
NDArraytype alias (npt.NDArray[Any]) instubs/sklearn/_typing.pyi. - Updated
MatrixLiketo use the newNDArrayalias instead ofnp.ndarray. - Switched several return/attribute annotations in
stubs/sklearn/linear_model/_base.pyifromnumpy.ndarraytoNDArray.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| stubs/sklearn/linear_model/_base.pyi | Replaces ndarray return/attribute types with the shared NDArray alias. |
| stubs/sklearn/_typing.pyi | Introduces NDArray = npt.NDArray[Any] and updates MatrixLike to use it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes some of the sklearn stubs to use
npt.NDArray[Any]instead ofnp.ndarray. This avoids pyright raisingreportUnknownMemberTypeerrors.If this change is accepted, I can modify the rest of the stubs for consistency.