Skip to content

[Open3d] new port#17423

Closed
fran6co wants to merge 2 commits into
microsoft:masterfrom
fran6co:open3d
Closed

[Open3d] new port#17423
fran6co wants to merge 2 commits into
microsoft:masterfrom
fran6co:open3d

Conversation

@fran6co

@fran6co fran6co commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

This is a rework of #12199

Depends on:

I disabled the GUI for now, I will enable it when I get filament working with it

@fran6co fran6co force-pushed the open3d branch 2 times, most recently from 8b6080b to e37a3de Compare April 21, 2021 15:43
@fran6co fran6co force-pushed the open3d branch 3 times, most recently from 45d855c to 34a73aa Compare April 21, 2021 16:14
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 22, 2021
Comment thread ports/poissonrecon/CONTROL Outdated
Comment thread ports/tinygltf/portfile.cmake Outdated
Comment thread ports/poissonrecon/intel-isl.patch Outdated
Comment thread ports/poissonrecon/CMakeLists.txt Outdated
@NancyLi1013 NancyLi1013 added depends:different-pr This PR or Issue depends on a PR which has been filed requires:author-response labels Apr 22, 2021
@fran6co fran6co force-pushed the open3d branch 3 times, most recently from d98b1cc to d514069 Compare April 22, 2021 11:02
This was referenced Apr 26, 2021
@NancyLi1013 NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label May 7, 2021
@fran6co fran6co force-pushed the open3d branch 3 times, most recently from 05805b5 to 855151a Compare May 10, 2021 09:19
@NancyLi1013

Copy link
Copy Markdown
Contributor

Open3d failed with the following errors:

-- Found PythonInterp: D:/installed/x86-windows/tools/python3/python.exe (found version "3.9.2") 
CMake Error at D:/installed/x86-windows/share/pybind11/FindPythonLibsNew.cmake:210 (message):
  Python libraries not found
Call Stack (most recent call first):
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  D:/installed/x86-windows/share/pybind11/pybind11Tools.cmake:38 (find_package)
  D:/installed/x86-windows/share/pybind11/pybind11Common.cmake:195 (include)
  D:/installed/x86-windows/share/pybind11/pybind11Config.cmake:249 (include)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  3rdparty/find_dependencies.cmake:726 (find_package)
  CMakeLists.txt:444 (include)

@fran6co

fran6co commented May 11, 2021

Copy link
Copy Markdown
Contributor Author

Open3d failed with the following errors:


-- Found PythonInterp: D:/installed/x86-windows/tools/python3/python.exe (found version "3.9.2") 

CMake Error at D:/installed/x86-windows/share/pybind11/FindPythonLibsNew.cmake:210 (message):

  Python libraries not found

Call Stack (most recent call first):

  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)

  D:/installed/x86-windows/share/pybind11/pybind11Tools.cmake:38 (find_package)

  D:/installed/x86-windows/share/pybind11/pybind11Common.cmake:195 (include)

  D:/installed/x86-windows/share/pybind11/pybind11Config.cmake:249 (include)

  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)

  3rdparty/find_dependencies.cmake:726 (find_package)

  CMakeLists.txt:444 (include)

It looks to be pybind11 not finding python. I couldn't get to build python with the latest vcpkg on windows, could that be related?

@ssheorey

ssheorey commented May 13, 2021

Copy link
Copy Markdown

@fran6co Open3D doesn't support Python 3.9.x as yet. Only 3.6-3.8.

@JackBoosY

Copy link
Copy Markdown
Contributor

@fran6co Open3D doesn't support Python 3.9.x as yet. Only 3.6-3.8.

If it's true, we should wait for the upstream to support newer Python.

@JackBoosY JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label May 25, 2021
@fran6co

fran6co commented May 26, 2021

Copy link
Copy Markdown
Contributor Author

I don't think the problem is python 3.9 given that I'm disabling all python stuff. Right now it's failing on windows inside pybind11 checks that technically are not needed given the current configuration but I haven't seen an easy way to turn it off

@ssheorey

Copy link
Copy Markdown

@fran6co Please see this issue isl-org/Open3D#3376
Python is still needed for the build process.
It should work if we can specify the full path to the Python executable as a CMake argument..

@Ulysses1337

Copy link
Copy Markdown
Contributor

I really appreciate your effort to take on this ill-designed behemoth. Presumably I'm not alone in my desire to just process point clouds. I don't want the bloat of an asset importer or renderer, neither do I want to inherit someone else's logger macros. Does it look like it will be feasible to make the major sideshows optional?

@fran6co

fran6co commented Aug 18, 2021 via email

Copy link
Copy Markdown
Contributor Author

@JackBoosY

Copy link
Copy Markdown
Contributor

Any progress here?

@fran6co

fran6co commented Sep 10, 2021

Copy link
Copy Markdown
Contributor Author

Might resume work on it in the next weeks, but no promises

@NancyLi1013

Copy link
Copy Markdown
Contributor

Need to resolve the conflicts. @fran6co

@NancyLi1013

Copy link
Copy Markdown
Contributor

Is work still being done for this PR? @fran6co

@fran6co

fran6co commented Nov 2, 2021

Copy link
Copy Markdown
Contributor Author

Is work still being done for this PR? @fran6co

No, I don’t have time to work on it

@NancyLi1013

Copy link
Copy Markdown
Contributor

Thanks for your contribution and response. @fran6co

We're closing this for now since there's been no progress for a long time. If you'd like to continue working on it, please reopen and ping us!

@NancyLi1013 NancyLi1013 closed this Nov 2, 2021
@hectorpiteau

hectorpiteau commented May 23, 2024

Copy link
Copy Markdown

@fran6co Is there a way to help you on this? I know it's been a while but it would be cool to reopen the issue

@QiuYilin

QiuYilin commented Jun 6, 2024

Copy link
Copy Markdown

Is there any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! depends:upstream-changes Waiting on a change to the upstream project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants