[jansson] update to 2.15.1#52693
Draft
ricardoofnl wants to merge 4 commits into
Draft
Conversation
BillyONeal
requested changes
Jul 3, 2026
BillyONeal
left a comment
Member
There was a problem hiding this comment.
GPT 5.5 observes the following and wrote ricardoofnl#2 which fixes it for you.
- The installed Windows Debug pkg-config metadata appears to advertise
Libs: -ljansson, while the Debug library is installed asjansson_d.lib, causing pkg-config Debug consumers to fail linking withLNK1104. This appears pre-existing because the portfile and upstreamjansson.pc.inare unchanged except for the version.- The port declares
"license": "MIT", but upstream's license text notes exceptions, including non-MITsrc/dtoa.c; upstream's default CMake option includes that code viaUSE_DTOA=ON. This also appears pre-existing.
ricardoofnl
commented
Jul 3, 2026
ricardoofnl
left a comment
Contributor
Author
There was a problem hiding this comment.
Both observations are correct and are now fixed, with one correction to the license identifier.
- Debug pkgconfig: confirmed. Upstream sets
CMAKE_DEBUG_POSTFIX=_don Windows (jansson_d.lib) butjansson.pckeeps-ljansson. The portfile now rewrites-ljansson->-ljansson_din the debug.pcon Windows (non-release-only builds). - License: confirmed that
USE_DTOAdefaultsON, sosrc/dtoa.cis compiled in, and its terms are not MIT. But the exception is not HPND: SPDX has a dedicated identifierdtoa(David M. Gay dtoa License) whose text matches jansson'ssrc/dtoa.cexception verbatim, whereas HPND has a different "name not used in advertising" clause the dtoa license lacks. So I usedMIT AND dtoarather thanMIT AND HPND. Also switched the copyright install tovcpkg_install_copyrightas in your PR.
vcpkg accepts MIT AND dtoa and the port builds. Thanks for the catch on both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.https://github.com/akheron/jansson/releases/tag/v2.15.1