[OpenSSL, Botan]: Remove JOM, it hangs.#52714
Conversation
5ca4c3f to
1859fe2
Compare
|
Jumping straight into a PR... I would like to see the actual versions of vcpkg, openssl, jom. It doesn't occur in vcpkg CI, and I don't think I see related issues. |
|
I've done some testing overnight, a bunch of builds: Of course this is overkill, but it is what I had available. We are on very current of everything. C:\s\vcpkg>git log 2b65c20 Up until around April this year, we hadn't updated Vcpkg for about 2 years. Our system also presently runs vcpkg twice concurently. I hope to still locally repro and debug jom, but have not yet. I can try newer Vcpkg but I doubt it will make a difference. |
We do have our own approximatelely 100 line triplet, so this would be adequate and welcome, for us. |
|
I'd check defender exclusions first. |
|
It does work sometimes, and when it does, in the usual 20-40 minutes. i.e. not slowed down hugely. |
|
C:\s>jom /version |
|
Maybe it requires higher core count? I think our builds machines are 52 core, hyperthreaded to 102. |
|
it looks like in triplet: will work. |
|
These are heavily used ports and they are not one of the known flaky ones so it would be better if we have some assurance that this actually fixes a real problem before proceeding. |
|
Yes, it is a huge help. I have the triplet change and I expect it will go forward. |
|
Clarification/repitition: We do not build Botan. We do build OpenSSL. I recommend removing jom from vcpkg entirely. Maybe even leave the ports alone but make PREFE_JOM do nothing, remove the support? Until/unless debugged? |
|
We've never seen OpenSSL hang for us, even with JOM. |
|
We see it I think more than 50% of runs. It is a big problem. |
|
Again, my proposal is to add a specific triplet variable such as |
We have been seeing many hangs in building OpenSSL.
i.e instead of our vcpkg taking around 40 minutes overall, it times out after 8 hours.
Every case I have looked at is in the middle of building OpenSSL with jom.
(We do not build Botan.)
While the investigation is yet quite shallow (haven't reproed locally and debugged) I strongly suspect a problem in jom.
Ongoing testing in our local cloud CI is occuring with:
set VCPKG_MAX_CONCURRENCY=1
So far 1-2 runs have succeeded but I'll run 10 or so.
./vcpkg x-add-version --alland committing the result.