Skip to content

[gtsam] Update to 4.2.2#52722

Open
SunBlack wants to merge 1 commit into
microsoft:masterfrom
SunBlack:gtsam
Open

[gtsam] Update to 4.2.2#52722
SunBlack wants to merge 1 commit into
microsoft:masterfrom
SunBlack:gtsam

Conversation

@SunBlack

@SunBlack SunBlack commented Jul 3, 2026

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Interesting fact: When building this port, you get (with TBB as dependency):

CMake Warning at cmake/HandleFinalChecks.cmake:3 (message):
  TBB 4.4 or newer was not found - this is ok, but note that GTSAM
  parallelization will be disabled.  Set GTSAM_WITH_TBB to 'Off' to avoid
  this warning.

// EDIT: After Adding CONFIGI get now:

--  Use Intel TBB                                    : Yes (Version: 2023.0.0)

Without adding CONFIG and just removing the if(0) from previos patch I'm getting:

--  Use Intel TBB                                    : TBB not found

@BillyONeal As TBB wasn't used before and no one complained: Adding tbb as optional feature?

@SunBlack SunBlack marked this pull request as draft July 4, 2026 10:07
@SunBlack SunBlack force-pushed the gtsam branch 3 times, most recently from 0e7e37d to a5d9e82 Compare July 4, 2026 17:24
@SunBlack SunBlack marked this pull request as ready for review July 4, 2026 20:54

@BillyONeal BillyONeal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillyONeal As TBB wasn't used before and no one complained: Adding tbb as optional feature?

I think either a feature or hard disabling it would be acceptable but I think we need to do one or the other

@BillyONeal BillyONeal marked this pull request as draft July 5, 2026 06:42
@SunBlack SunBlack marked this pull request as ready for review July 5, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants