Harden release publishing and signing restore for CFS network isolation#826
Merged
Merged
Conversation
Pin the release and pre-release publish jobs to @vscode/vsce@3.9.1 (whose full dependency closure is saved in the cpp_PublicPackages CFS feed, so the global install resolves anonymously under isolation; 3.1.0's closure is not reliably saved). Install with --include=optional --ignore-scripts=false --force, rebuild the vsce-sign native binary, and verify it via Node module resolution -- in a global install @vscode/vsce-sign is nested under @vscode/vsce/node_modules, so a hardcoded top-level path check is wrong. Route the MicroBuild signing 'nuget restore' through a committed build/NuGet.config (clear + devdiv/MicroBuildToolset) so it no longer reaches nuget.org under CFSClean.
snehara99
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build and release pipelines to improve the handling of NuGet and npm dependencies, particularly for the VSCE (Visual Studio Code Extension) publishing tool and its native signing binary. The changes ensure more reliable dependency resolution and signing during the build and release process.
Dependency management improvements:
NuGet.configfile in thebuilddirectory to specify a custom package source for NuGet restores, improving reliability and control over package resolution.jobs/shared/build.ymlto explicitly use the newNuGet.config, ensuring the correct configuration is applied during package restoration.VSCE toolchain and signing reliability:
@vscode/vscefrom version 3.1.0 to 3.9.1 and added additional npm flags for more robust installation in bothjobs/release/prerelease.ymlandjobs/release/release.yml. [1] [2]@vscode/vsce-signnative binary globally and verify its correct resolution and functionality using a PowerShell script. This ensures the signing tool is properly available and matches howvsce publishexpects it, reducing the risk of signing failures. [1] [2]