Integrate upstream PR #130: Fix extension method bugs#2
Open
mistial-dev wants to merge 3 commits into
Open
Conversation
…called extension method in each userdata instance example : userdata.ExtMethod1() --called fine userdata.ExtMethod2() --null indexer!
… case when multiple extension methods with similar signature were available in different extension classes, and one of the extension methods has generic argument as extendable type: TweenSettingsExtensions.SetEase<T>(this T t, Ease ease) where T : Tween; //this one cause exception shot upon calling SetEase SpecialTweenExtensions.SetEase(this Tweener @this, Ease ease)
Generic extension exception and multiple extension methos for single userdata: fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the fixes from upstream PR moonsharp-devs#130 by @havietisov.
Fixes
GetGenericTypeDefinition()on generic parametersChanges
DispatchingUserDataDescriptor.csthat was preventing multiple extension method calls\!extensionType.IsGenericParametercheck inExtensionMethodsRegistry.csto fix exceptions with generic extension methodsOriginal PR has been open since 2016 and addresses legitimate bugs that affect Unity developers using libraries like DOTween.