fix: handle category dtype for target column in _build_dataframe#823
Open
Apoorv-c wants to merge 1 commit into
Open
fix: handle category dtype for target column in _build_dataframe#823Apoorv-c wants to merge 1 commit into
Apoorv-c wants to merge 1 commit into
Conversation
When users convert numeric-coded columns to pandas category dtype and pass them as the target y, downstream libraries (LightGBM, etc.) raise: ValueError: pandas dtypes must be int, float or bool. Fields with bad pandas dtypes: target: category Fix: in _build_dataframe, detect pd.Series with CategoricalDtype and convert to the underlying numeric or object dtype before any processing. Also fix _save_data_info to correctly identify numeric category targets. Fixes mljar#652
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users convert numeric-coded columns to pandas category dtype and pass them as the target y, downstream libraries (LightGBM, etc.) raise:
ValueError: pandas dtypes must be int, float or bool.
Fields with bad pandas dtypes: target: category
Fix: in _build_dataframe, detect pd.Series with CategoricalDtype and convert to the underlying numeric or object dtype before any processing. Also fix _save_data_info to correctly identify numeric category targets.
Fixes #652