Replace tmpnam with mkstemp/GetTempFileName in temporaryFileName#4795
Draft
AnHeuermann wants to merge 1 commit into
Draft
Replace tmpnam with mkstemp/GetTempFileName in temporaryFileName#4795AnHeuermann wants to merge 1 commit into
AnHeuermann wants to merge 1 commit into
Conversation
tmpnam is deprecated and has a dangerous race condition:
* On POSIX, atomically create the file itself via `mkstemp`
* Respect environment variable `TMPDIR`, fall back to `P_tmpdir` or
`/tmp`.
* On Windows, use `GetTempPathA`/`GetTempFileNameA`, which also
atomically create the file.
* Update Files.mo documention
* Function returns the path of a freshly created empty file rather
than a name that does not yet exist.
* Drop the now-obsolete race-condition warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4794.
Changes
tmpnamis deprecated and has a dangerous race condition:mkstempTMPDIR, fall back toP_tmpdiror/tmp.GetTempPathA/GetTempFileNameA, which also atomically create the file.