chore(api): remove dead field-config override endpoints#383
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
Drop no-op removeFieldOverride/saveFieldsConfig shims and the DELETE page-fields route after ms3_field_config_overrides was removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Удаляет deprecated override API после drop таблицы
ms3_field_config_overrides: маршрутDELETE /api/mgr/config/page-fields/{page_key}/{field_name},ConfigController::deleteFieldOverride, no-opConfigService::removeFieldOverrideиFieldConfigManager::saveFieldsConfig.Актуальный путь сохранён:
PUT /api/mgr/config/page-fields/{page_key}→ConfigService::saveFieldsConfig(array $fields)пишет вms3_product_fields. Убраны неиспользуемые параметры$pageKey/$contextKeyу save.Тип изменений
Связанные Issues
Closes #347
Как это было протестировано?
Grep: callers deprecated API = 0. Vue зовёт только GET/PUT page-fields.
php -lна изменённых PHP.Конфигурация тестирования:
chore/remove-dead-field-config-overrides-347php -lСкриншоты (если применимо)
Чеклист
Дополнительные заметки
DELETE …/page-fields/{page_key}/{field_name}больше нет (раньше был no-op success). Внешние клиенты получат 404 роутера.OrderService::save/remove@deprecated не трогали — отдельно, как в issue.