fix(customer): stop checkout token takeover via email#391
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
When a guest checkout matches an existing msCustomer by email, attach the order only — do not overwrite token or auto-login the attacker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Гость на checkout с email существующего покупателя больше не переписывает
msCustomer.tokenи не получает auto-login. Заказ по-прежнему может привязаться кcustomer_idпо email; сессия жертвы не передаётся.Убраны оба пути: в
getOrCreate()и вcreateFromOrderData()после неудачной auto-регистрации.Тип изменений
Связанные Issues
Closes #369
Как это было протестировано?
php -lнаCustomer.php. Сценарий из issue (guest checkout → victim email → проверка token) в этой сессии не гонял на живом MODX.Конфигурация тестирования:
fix/369-checkout-customer-token-takeoverphp -lСкриншоты (если применимо)
Чеклист
Дополнительные заметки
Severity: critical authz. После merge: инкогнито → cart → checkout с email существующего клиента → у жертвы
tokenне меняется; у атакующего нетcustomer_id/cookie жертвы. Auto-login по-прежнему только для нового customer приms3_customer_auto_login_on_order.