fix(order): return error when status save fails#392
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
OrderStatusService::change no longer returns true after a failed msOrder::save(); callers get ms3_err_unknown instead of a false success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
OrderStatusService::changeприmsOrder::save() === falseбольше не возвращаетtrue. Callers (OrderSubmitHandler, finalize, mgr, customer cancel) получаютms3_err_unknownи не идут по success-path.Логика выровнена early-return: лог/события/уведомления только после успешного save.
Тип изменений
Связанные Issues
Closes #376
Как это было протестировано?
php -lнаOrderStatusService.php. Симуляцию fail save на живом MODX не гонял.Конфигурация тестирования:
fix/376-order-status-save-falsephp -lСкриншоты (если применимо)
Чеклист
Дополнительные заметки
Не #207. Атомарность submit (create event до status) — вне scope, как в issue. Callers уже проверяют
$result !== true.