fix(user): migrate lastReultHashes to lastResultHashes safely (@Tryhard-source)#8055
fix(user): migrate lastReultHashes to lastResultHashes safely (@Tryhard-source)#8055Tryhard-source wants to merge 9 commits into
Conversation
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
|
I'm not a maintainer or a contributor but fwiw this LGTM. |
fehmer
left a comment
There was a problem hiding this comment.
hi @Tryhard-source,
please revert the unrelated changes in the markdown files.
…TypeScript mismatch during migration. All checks passing locally.
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Cleaned up the PR changes... there were some unintended formatting changes. (likely from Prettier) I’ve reverted those and reduced the diff to only the intended backend change (fixing lastResultHashes typo + migrating legacy field). The PR now contains only the relevant changes. Thanks! |
fehmer
left a comment
There was a problem hiding this comment.
Please check all my comments from the first review
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
|
Addressed the remaining review comments and fixed the lint issue. |
|
hi @Tryhard-source , i removed the last usage of the old property with the typo and both properties from the user response, please have a look. |
|
@fehmer Looks good to me. Thanks! |
Implements the changes requested in #7830.
This PR migrates the legacy
lastReultHashesfield tolastResultHashesusing a soft migration approach to avoid requiring a full database migration.Changes:
lastResultHashesto DBUserlastReultHashesfor backward compatibilitylastResultHashes ?? lastReultHashes ?? []lastResultHasheslastReultHasheson updatemigrateUserThis ensures existing user data remains compatible while gradually moving to the corrected schema.
Related issues: