fix(quick-restart): handle quick restart in long tests (@Leonabcd123)#8060
Open
Leonabcd123 wants to merge 38 commits into
Open
fix(quick-restart): handle quick restart in long tests (@Leonabcd123)#8060Leonabcd123 wants to merge 38 commits into
Leonabcd123 wants to merge 38 commits into
Conversation
github-actions
Bot
added
the
waiting for review
This reverts commit e1d61f7.
Member
|
We recently updated tanstack/hotkeys. Could you verify the issue already existed with the old version? Thanks |
Contributor
Author
Tested on 4a1e6f7 (one commit before the |
github-actions
Bot
removed
the
waiting for review
github-actions
Bot
added
the
waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8059
createHotkeysthat functions as a wrapper around@tanstack/hotkeys'screateHotkeys.hotkeys.quickRestartchanges. All other reactive value changes are ignored.createHotkeys, and change their creation order, such that primary quick restart hotkey is created last. This is so the secondary hotkey won't override the primary hotkey when test isn't long.