Skip to content

Added destroy method (Issue #8)#11

Open
aaronstillwell wants to merge 8 commits into
mosop:masterfrom
aaronstillwell:master
Open

Added destroy method (Issue #8)#11
aaronstillwell wants to merge 8 commits into
mosop:masterfrom
aaronstillwell:master

Conversation

@aaronstillwell

Copy link
Copy Markdown

Prompt is provided for deleting files when in interactive mode as per my discussion with @marksiemers

An accompanying spec will follow shortly

@marksiemers marksiemers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if NOT in interactive mode, this won't prompt the user at all?

If that is the case, we had a mis-communication. I think no matter what, the user should be asked once to confirm that that want to delete all the files.

Optionally (if you want to do more work for this PR), Interactive mode will prompt once per file that will be deleted.

@aaronstillwell

Copy link
Copy Markdown
Author

@marksiemers understood, I'll follow up with a modification for the behaviour you've described + I'll resolve the failing CI build.

Also includes destroyed/skipped messages
@aaronstillwell

Copy link
Copy Markdown
Author

@marksiemers the behaviour implemented by this PR should now match your expectations. I'm still to follow up with a spec.

I believe the currently failing test is resolved by #10.

@faustinoaq

Copy link
Copy Markdown

Hi @mosop Does this still fix #8 ? 😅

@marksiemers

Copy link
Copy Markdown

@mosop - Can this be merged or closed?

I realize some conflicts will have to be resolved in order to merge, but if it's just going to be closed, no need to resolve them.

@drujensen

Copy link
Copy Markdown
Contributor

@aaronstillwell @marksiemers can you resolve the conflicts? I can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants