merino/relevancy/suggest: Refactorings for uniffi_parse_rs#7419
Open
bendk wants to merge 1 commit into
Open
Conversation
I'm working on a new UniFFI parser (mozilla/uniffi-rs#2841) and it currently has a couple extra requirements for types used in exported functions: * The types are publicly available from other crates. * The name matches the one used in the `custom_type!` macro. * Macro expansion is not supported, the types need to be written out by hand. I could maybe rework the parser to avoid these requirements, but the first two the changes feel like improvements to me. Not being able to use macros for UniFFIed types is worse but I don't think it will affect us all that much in practice. Please push back if you don't think so.
Contributor
Author
|
I'm going to be opening several of these issues. I feel like this one is the most controversial since the "no macros" rule is a real limitation. Please tell me if you think that's going to negatively affect you too badly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a new UniFFI parser
(mozilla/uniffi-rs#2841) and it currently has a couple extra requirements for types used in exported functions:
custom_type!macro.I could maybe rework the parser to avoid these requirements, but the first two the changes feel like improvements to me. Not being able to use macros for UniFFIed types is worse but I don't think it will affect us all that much in practice. Please push back if you don't think so.
Pull Request checklist
[ci full]to the PR title.