Skip to content

relay: ensure API types are public#7424

Open
bendk wants to merge 1 commit into
mozilla:mainfrom
bendk:bdk/push-kzssulpstnwy
Open

relay: ensure API types are public#7424
bendk wants to merge 1 commit into
mozilla:mainfrom
bendk:bdk/push-kzssulpstnwy

Conversation

@bendk

@bendk bendk commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

I'm working on a new UniFFI parser
(mozilla/uniffi-rs#2841) and it currently requires that types used in the exported functions are publicly available from other crates.

I could maybe rework the parser to handle this another way, but this feels cleaner to me anyways. It feels weird if a type can be used by foreign languages but not other Rust crates.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

I'm working on a new UniFFI parser
(mozilla/uniffi-rs#2841) and it currently
requires that types used in the exported functions are publicly
available from other crates.

I could maybe rework the parser to handle this another way, but this
feels cleaner to me anyways.  It feels weird if a type can be used by
foreign languages but not other Rust crates.
@bendk bendk requested a review from groovecoder June 15, 2026 18:46
@bendk bendk assigned bendk and unassigned bendk Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant