Split mxenv into pip and uv environment variants#73
Draft
jensens wants to merge 17 commits into
Draft
Conversation
…rd, loadTestsFromModule
Test each variant against a properly generated Makefile (uv variant needs global uv; pip variant via mxmake update) instead of overriding PYTHON_PACKAGE_INSTALLER on a variant-locked Makefile. Drop obsolete uv-local-install scenarios; rely on test.yml for Windows coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the single, heavily-branched
core.mxenvdomain with a shared base plus two thin environment variants, and routes dev-tool execution behind variant-provided macros so QA tool files stay world-agnostic. Supersedes #67 (theTOOL_RUNNERtoggle); this approach is simpler and keeps pip as a deliberate fallback.Two orthogonal concerns are now cleanly separated:
uvx) → variant-defined macros (INSTALL_TOOL/RUN_TOOL/UNINSTALL_TOOL).This is a major release (3.0.0) with a breaking change to mxenv configuration; see
docs/source/migration.md.What changed
core.mxenvis now an abstract base; newcore.mxenv-pipandcore.mxenv-uvvariants provide provisioning + macros. Every other domain keepsdepends = core.mxenvunchanged.PYTHON_PACKAGE_INSTALLERdefinition is visible to downstream domains (packages.mketc.).mxmake updatereads the previousPYTHON_PACKAGE_INSTALLERvalue to pick the matching variant on migration (pip users stay on pip; default is uv).uvxby default under the uv variant. Type-checkers (mypy, ty, pyrefly) always install into the environment.UV_PROVISION=pip|syncandTOOL_EXECUTION=uvx|venv.PYTHON_PACKAGE_INSTALLER/UV_PYTHONsettings on the base; local-uv-into-venv fallback; "uv outdated" warning.tydiagnostics (generic template decorator, aNoneguard, modern test loader) so typecheck is clean.Design spec and implementation plan are under
docs/superpowers/.Test plan
pytestfull suite — 39 passedpackages; swap-variant +updateflips the world; legacy pip Makefile stays pip on updatemake install(uv variant),make test,make check(ruff via uvx + ty) all passmake typecheck(ty) — clean (pre-existing diagnostics fixed in this branch)