[Telemetry 1/4] Add telemetry hooks to Neo core#4372
Open
Jim8y wants to merge 2 commits into
Open
Conversation
4 tasks
Contributor
Author
shargon
reviewed
Dec 14, 2025
shargon
approved these changes
Dec 26, 2025
| localNode.RemoteNodes.TryAdd(Self, this); | ||
| var listenPort = config.Tcp?.Port; | ||
| _connectionDirection = listenPort.HasValue && local.Port == listenPort.Value ? ConnectionDirection.Inbound : ConnectionDirection.Outbound; | ||
| NotifyConnectionChanged(true, ConnectionChangeReason.Connected); |
ajara87
approved these changes
Dec 29, 2025
erikzhang
reviewed
Dec 30, 2025
| /// But it also depends on <see cref="UnhandledExceptionPolicy"/>. | ||
| /// </summary> | ||
| internal bool IsStopped { get; set; } | ||
| protected internal bool IsStopped { get; set; } |
Member
There was a problem hiding this comment.
The getter can be public, but the setter should be internal or private.
erikzhang
reviewed
Dec 30, 2025
| _ack = false; | ||
| // Here it is possible that we dont have the Version message yet, | ||
| // so we need to send the message uncompressed | ||
| SafeInvoke(() => MessageSent?.Invoke(_system, message)); |
Member
There was a problem hiding this comment.
Why SafeInvoke? I think exceptions should be handled correctly.
cschuchardt88
added
Waiting for Review
Downstream
Wi1l-B0t
approved these changes
Jan 16, 2026
erikzhang
requested changes
Jan 16, 2026
erikzhang
left a comment
erikzhang
left a comment
Member
There was a problem hiding this comment.
Some conversations are still unresolved. Please do not merge it yet.
Contributor
|
No Progress? @Jim8y |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds static event hooks to the Neo core P2P layer to enable telemetry collection without modifying the core behavior.
Changes
MessageSentevent toRemoteNodefor tracking outgoing messagesConnectionChangedevent for monitoring peer connection lifecycleFiles Changed
src/Neo/Network/P2P/RemoteNode.csTest Plan
Part of Telemetry Feature
This is PR 1 of 4 for adding comprehensive telemetry support to Neo nodes:
Related to #4376