Improve receive request flow#34
Closed
Jim8y wants to merge 3 commits into
Closed
Conversation
Contributor
Author
Contributor
Author
|
Split follow-up for easier review:
This keeps the first Receive change around the same review size as PR #33. |
Contributor
Author
|
Closing in favor of smaller receive-flow PRs. The ReceivePage payment-request redesign ships in #39 (which also completes zh-Hant); the remaining Scan->Send payment-request metadata round-trip (memo/data pass-through + decode hardening) will be opened as a separate small PR carved from this branch. The branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Purpose
This PR is the second small P2 wallet UX improvement and focuses only on the receive/payment-request flow. It turns the old static receive QR page into a clearer, more useful wallet receive request experience without changing transaction signing, dAPI, RPC selection, wallet storage, or send execution.
What changed
neo:URI now includes optionalasset, positiveamount,memo, anddataquery parameters.ScanPageand shows memo/data as read-only request details onSendPage.amount=1.23behaves consistently across device languages.Out of scope
Validation
xmllint --noout OneGateApp/Pages/ReceivePage.xaml OneGateApp/Pages/SendPage.xaml OneGateApp/Properties/Strings.resx OneGateApp/Properties/Strings.zh-Hans.resxgit diff --checkdotnet build OneGateApp/OneGateApp.csproj -f net10.0-android -p:RuntimeIdentifier=android-arm64 -p:EmbedAssembliesIntoApk=truedotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -p:RuntimeIdentifier=iossimulator-arm64 -p:EnableCodeSigning=false -p:CodesignKey= -p:CodesignProvision= -p:ProvisioningType=automaticonegate_api36, opened the Receive page, verified layout, scrolling, and receive action buttons are reachable. Screenshot will be added as a PR comment, not committed to the repository.xcode-selectpoints to CommandLineTools and the accessibility tooling requires full Xcode selection via sudo; directsimctl launchwas inconsistent on this simulator, so iOS validation is build-level for this PR.dotnet testis not available.Known existing warnings:
NU1903forSQLitePCLRaw.*packages and iOS asset duplicateMT7158warnings were observed; they are pre-existing and not introduced by this PR.目的
这个 PR 是第二个小型 P2 钱包体验优化,只聚焦收款/付款请求流程。它把旧的静态收款二维码页升级成更清晰、更有用的钱包收款请求体验,不改变交易签名、dAPI、RPC 选择、钱包存储或发送执行逻辑。
修改内容
neo:URI 现在会包含可选的asset、正数amount、memo和data查询参数。ScanPage中保留扫码得到的付款请求元数据,并在SendPage中以只读请求详情展示 memo/data。amount=1.23在不同设备语言下行为一致。不在范围内
验证
xmllint --noout OneGateApp/Pages/ReceivePage.xaml OneGateApp/Pages/SendPage.xaml OneGateApp/Properties/Strings.resx OneGateApp/Properties/Strings.zh-Hans.resxgit diff --checkdotnet build OneGateApp/OneGateApp.csproj -f net10.0-android -p:RuntimeIdentifier=android-arm64 -p:EmbedAssembliesIntoApk=truedotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -p:RuntimeIdentifier=iossimulator-arm64 -p:EnableCodeSigning=false -p:CodesignKey= -p:CodesignProvision= -p:ProvisioningType=automaticonegate_api36上启动应用,打开 Receive 页面,验证布局、滚动和收款操作按钮可达。截图会以 PR 评论形式添加,不提交进代码库。xcode-select指向 CommandLineTools,而可访问性工具需要通过 sudo 切到完整 Xcode;当前 simulator 的直接simctl launch也不稳定,所以这个 PR 的 iOS 验证覆盖到 build 级别。dotnet test。已知既有警告:观察到
SQLitePCLRaw.*包的NU1903警告和 iOS asset duplicateMT7158警告;这些是既有问题,不是本 PR 引入。