feat(capabilities): dynamic mimetype discovery from wopi xml#5754
Open
multiphlow wants to merge 3 commits into
Open
feat(capabilities): dynamic mimetype discovery from wopi xml#5754multiphlow wants to merge 3 commits into
multiphlow wants to merge 3 commits into
Conversation
97602f5 to
2ffa5bf
Compare
Collaborator
|
Thanks for opening your first pull request here, it means a lot that you want to contribute. This change is especially welcome. In order to get this in, it would be nice if you could address the following:
If you need help with any of those, please feel free to reach out; I'm more than happy to assist! |
Member
|
Actually the cypress failures seem indeed related and seem to tigger a javascript error: |
46efc8f to
497cf2d
Compare
Author
|
@juliusknorr A while ago I fixed the issue with array_unique. |
Signed-off-by: Florian Wagner <f.wagner81@gmail.com>
Signed-off-by: Florian Wagner <f.wagner81@gmail.com>
Signed-off-by: Florian Wagner <f.wagner81@gmail.com>
e61b85b to
b3827c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5742. This PR introduces dynamic mimetype discovery by parsing the WOPI discovery.xml using XPath, fallback in Capabilities is the static mimetypes array to ensure core stability.
Note: There are still some files in the code where Capabilities::MIMETYPES is used. This has to be correctly changed via dependency injection to use the new dynamic obtaining of the MIMETYPES
Furthermore a/some UnitTest(s) would also be required in DiscoveryServiceTest class.
Further on the discovery endpoint does not yet provide categories for the mimetypes.