chore: handle closing change feed stream and logReader during exceptions#150
Draft
adam-miller wants to merge 1 commit into
Draft
chore: handle closing change feed stream and logReader during exceptions#150adam-miller wants to merge 1 commit into
adam-miller wants to merge 1 commit into
Conversation
|
Member
|
Looks reasonable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet tested, but this is an attempt to:
Handle closing log reader when it's been passed off to the stream. During exceptions, like the client disconnecting before reading everything, the handle will get dropped without being closed. If we make the stream
Closeable, we can ensure it is closed during response exceptions.