Fix automatically generating targets for downloaded plugins#45
Open
fcturan20 wants to merge 1 commit into
Open
Fix automatically generating targets for downloaded plugins#45fcturan20 wants to merge 1 commit into
fcturan20 wants to merge 1 commit into
Conversation
caner-milko
reviewed
Dec 25, 2025
| endif() | ||
|
|
||
| nos_get_package_info_by_path(${plugin} plugin_name plugin_version plugin_json) | ||
| message("Plugin version: ${plugin_version}") |
There was a problem hiding this comment.
I don't think we need this message
caner-milko
reviewed
Dec 25, 2025
| endfunction() | ||
|
|
||
| function(_nos_configure_plugin_dir dir common_dependencies common_definitions) | ||
| function(_nos_configure_plugin_dir dir plugin common_dependencies common_definitions) |
There was a problem hiding this comment.
If This function only works on a single plugin manifest file, then loops the directory, I think we can separate them?
fcturan20
force-pushed
the
improve-downloaded-plugin-detection
branch
from
December 25, 2025 11:09
b86ed25 to
09e7ffe
Compare
fcturan20
force-pushed
the
improve-downloaded-plugin-detection
branch
from
January 14, 2026 16:45
09e7ffe to
6ac92f7
Compare
shamilatesoglu
force-pushed
the
dev
branch
2 times, most recently
from
March 31, 2026 15:40
161a349 to
ebce595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.