sn/object: move placement logic into shared service#4030
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4030 +/- ##
==========================================
- Coverage 26.76% 26.72% -0.05%
==========================================
Files 688 688
Lines 46721 46625 -96
==========================================
- Hits 12506 12459 -47
+ Misses 33067 33033 -34
+ Partials 1148 1133 -15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Jun 22, 2026
roman-khimov
left a comment
roman-khimov
left a comment
Member
There was a problem hiding this comment.
Neat.
There are also calls to ContainerNodes() in IR and CLI, but CLI is a one-shot thing and IR events are rather rare, per-epoch ones are useless, load processing can benefit from this cache, but it's not critical there either.
Member
|
Rebase, please. |
Move placement building and caching logic from `cmd/neofs-node` into `pkg/services/object/placement`. Reuse the shared placement service in object and control code paths. Closes #1803. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
cthulhu-rider
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1803.