Fix split streaming#4042
Merged
Merged
Conversation
Handle virtual children in pipelined split assembly by falling back to the regular recursive get path. Preserve headers in payload-only mode so child validation still works. Closes #4041. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Mark the response as started when pipelined child payload is written, matching the non-pipelined streaming paths. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4042 +/- ##
==========================================
+ Coverage 26.72% 26.75% +0.02%
==========================================
Files 688 688
Lines 46634 46652 +18
==========================================
+ Hits 12463 12480 +17
- Misses 33038 33039 +1
Partials 1133 1133 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Jun 24, 2026
|
|
||
| if s.se.status != statusOK { | ||
| if s.se.status == statusVIRTUAL { | ||
| if exec.copyChild(s.id, s.rng, checkHdr) { |
Member
There was a problem hiding this comment.
Likely can be optimized, but works as a fix.
Merged
roman-khimov
added a commit
that referenced
this pull request
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4041.