Skip to content

Fix range#4051

Merged
roman-khimov merged 3 commits into
masterfrom
fix-range-split
Jun 26, 2026
Merged

Fix range#4051
roman-khimov merged 3 commits into
masterfrom
fix-range-split

Conversation

@End-rey

@End-rey End-rey commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Closes #4049.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.78%. Comparing base (0af16a2) to head (4225598).

Files with missing lines Patch % Lines
pkg/local_object_storage/blobstor/fstree/fstree.go 60.00% 1 Missing and 1 partial ⚠️
pkg/services/object/head/remote.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4051      +/-   ##
==========================================
+ Coverage   26.77%   26.78%   +0.01%     
==========================================
  Files         688      688              
  Lines       46674    46679       +5     
==========================================
+ Hits        12497    12505       +8     
+ Misses      33044    33039       -5     
- Partials     1133     1135       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pkg/local_object_storage/blobstor/fstree/fstree.go
End-rey added 2 commits June 26, 2026 22:46
FSTree range streams could return more bytes than requested when a non-zero
range offset started inside the already buffered payload prefix and the
requested range also ended there. This made ranged GET over split objects
occasionally fail with payload size overflow.

Closes #4049.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Use the standard offset, length order for remote `GetRange` calls used by EC
policer recovery. The previous signature named the arguments in the opposite
order, causing callers to pass offset and length as swapped values.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
@roman-khimov roman-khimov merged commit 7e8699b into master Jun 26, 2026
22 checks passed
@roman-khimov roman-khimov deleted the fix-range-split branch June 26, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ranged GET test failure for complex object

2 participants