Skip to content

feat(events): add icalUid to ListEventQueryParams#738

Merged
radenkovic merged 1 commit into
mainfrom
nines/CUST-5473-add-ical-uid-query-param
Jun 16, 2026
Merged

feat(events): add icalUid to ListEventQueryParams#738
radenkovic merged 1 commit into
mainfrom
nines/CUST-5473-add-ical-uid-query-param

Conversation

@openclaw-sre-agent

@openclaw-sre-agent openclaw-sre-agent Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Add the missing icalUid optional field to ListEventQueryParams so customers can filter events by iCalendar UID without casting queryParams to any.

Root Cause

ListEventQueryParams has 17 typed fields but icalUid / ical_uid was never included, even though the v3 API accepts it on GET /v3/grants/{identifier}/events and the Event response model already has icalUid at line 84. A related PR that added the attendees filter missed this field.

Fix

Single-field addition: icalUid?: string on the query params interface. The SDK's apiClient already converts camelCase keys to snake_case in query parameters, so icalUid is sent as ical_uid on the wire — no serialization changes needed.

Before / After

// Before — requires unsafe cast
await nylas.events.list({
  identifier: grantId,
  queryParams: {
    calendar_id: calId,
    ical_uid: uid,
  } as any,
});

// After — fully typed
await nylas.events.list({
  identifier: grantId,
  queryParams: {
    calendarId: calId,
    icalUid: uid,
  },
});

Validation

  • tsc --noEmit passes cleanly
  • No other files affected

Fixes CUST-5473

Add the missing icalUid optional field to ListEventQueryParams so
customers can filter events by iCalendar UID without casting to any.

The SDK's apiClient already converts camelCase keys to snake_case in
query parameters, so icalUid is sent as ical_uid on the wire —
matching the v3 API contract.

Fixes CUST-5473
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.90%. Comparing base (8277c12) to head (6ce7e79).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files          42       42           
  Lines        1006     1006           
  Branches       90       90           
=======================================
  Hits          995      995           
  Misses         11       11           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@radenkovic radenkovic merged commit 6a4734a into main Jun 16, 2026
10 checks passed
@radenkovic radenkovic mentioned this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant