feat(events): add icalUid to ListEventQueryParams#738
Merged
Conversation
Add the missing icalUid optional field to ListEventQueryParams so customers can filter events by iCalendar UID without casting to any. The SDK's apiClient already converts camelCase keys to snake_case in query parameters, so icalUid is sent as ical_uid on the wire — matching the v3 API contract. Fixes CUST-5473
radenkovic
approved these changes
Jun 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 42 42
Lines 1006 1006
Branches 90 90
=======================================
Hits 995 995
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the missing
icalUidoptional field toListEventQueryParamsso customers can filter events by iCalendar UID without castingqueryParamstoany.Root Cause
ListEventQueryParamshas 17 typed fields buticalUid/ical_uidwas never included, even though the v3 API accepts it onGET /v3/grants/{identifier}/eventsand theEventresponse model already hasicalUidat line 84. A related PR that added theattendeesfilter missed this field.Fix
Single-field addition:
icalUid?: stringon the query params interface. The SDK'sapiClientalready converts camelCase keys to snake_case in query parameters, soicalUidis sent asical_uidon the wire — no serialization changes needed.Before / After
Validation
tsc --noEmitpasses cleanlyFixes CUST-5473