ffmpeg on riscv64#168
Open
samuelmarinsoto wants to merge 7 commits into
Open
Conversation
dav1d won't build without the x86 defs defined and set to 0 on riscv64
Gated x86-only features in config.h, and used paths[[]] to select source files for each architecture
Contributor
Author
|
There are regressions with x86 builds, mainly due to redefinitions. I think its because awk is writing multiple defines into config.asm in dav1d and ffmpeg, but I'm not sure yet. |
unifdef is needed to generate temporary header files that awk/sed/etc. can modify without producing redefines. This adds unifdef as a build dependency
the awk expression would make redefined macros due to the new arch guards in config.h. Pass config.h through unifdef first
the awk expression would make redefined macros due to the new arch guards in config.h. Pass config.h throughunifdef first.
Contributor
Author
|
Ok, I fixed the issue by using unifdef to evaluate the config.h's into a temporary header file without redefines. All packages build on x86_64 and riscv64. This does add unifdef as a build dependency. I think its minimal enough for oasis, but perhaps we could use the cpp ninja rule instead, if you prefer it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to build ffmpeg, mpv, and dav1d on a riscv64 toolchain on an x86_64 alpine host. I believe these are the last packages. All sets now build with a riscv64 cross toolchain!