cmake: Fix default installation directory backslash on Windows#166
Open
qhouz wants to merge 1 commit into
Open
cmake: Fix default installation directory backslash on Windows#166qhouz wants to merge 1 commit into
qhouz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
file(TO_CMAKE_PATH ...)to normalize the path obtained from$ENV{ALLUSERSPROFILE}before assigning it to
CMAKE_INSTALL_PREFIX.Motivation and Context
$ENV{ALLUSERSPROFILE}on Windows expands toC:\ProgramData— a path with backslashes.CMake treats backslashes as escape sequences inside strings, causing a parse error when
running
cmake --install:How Has This Been Tested?
Tested on Windows 11 x64 with Visual Studio 2026.
Ran
cmake --preset windows-x64,cmake --build --preset windows-x64 --config Debug,and
cmake --install build_x64 --config Debug— no errors.Types of changes
Checklist: