Skip to content

Refactor/youtube api client#13555

Closed
xakep8 wants to merge 3 commits into
obsproject:masterfrom
xakep8:refactor/YoutubeApiClient
Closed

Refactor/youtube api client#13555
xakep8 wants to merge 3 commits into
obsproject:masterfrom
xakep8:refactor/YoutubeApiClient

Conversation

@xakep8

@xakep8 xakep8 commented Jun 14, 2026

Copy link
Copy Markdown

Description

Created YoutubeApiClient and moved the broadcast and stream related functions from YoutubeApiWrappers to YoutubeApiClient and added apiClient object to YoutubeApiWrappers. This helps move the mixed ownership issue from YoutubeApiWrappers inheriting from YoutubeAuth only because it needs OAuth information, follow up refactor would be to move the broadcast setup/start/stop out to YoutubeBroadcastController and create a YoutubeService class which owns the OAuthTokenStore, YoutubeApiClient, YoutubeBroadcastController and the YoutubeDockController.

Motivation and Context

#13482 (comment)

How Has This Been Tested?

xcodebuild -configuration RelWithDebInfo -scheme obs-studio -parallelizeTargets -destination "generic/platform=macOS,name=Any Mac"

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@xakep8 xakep8 marked this pull request as ready for review June 14, 2026 05:40
xakep8 added 3 commits June 18, 2026 06:08
Created YoutubeApiClient and moved the broadcast and stream related
functions from YoutubeApiWrappers to YoutubeApiClient and added
apiClient object to YoutubeApiWrappers. This helps move the mixed
ownership issue from YoutubeApiWrappers inheriting from YoutubeAuth only
because it needs OAuth information, follow up refactor would be to move
the broadcast setup/start/stop out to YoutubeBroadcastController and
create a YoutubeService class which owns the OAuthTokenStore,
YoutubeApiClient, YoutubeBroadcastController and the
YoutubeDockController.
@xakep8 xakep8 force-pushed the refactor/YoutubeApiClient branch from c4b8cb7 to b1ec864 Compare June 18, 2026 00:38
@xakep8 xakep8 closed this Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants