Skip to content

obs-scripting: Add obs_properties_add_button2#13584

Open
exeldro wants to merge 1 commit into
obsproject:masterfrom
exeldro:script_button2
Open

obs-scripting: Add obs_properties_add_button2#13584
exeldro wants to merge 1 commit into
obsproject:masterfrom
exeldro:script_button2

Conversation

@exeldro

@exeldro exeldro commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

Add obs_properties_add_button2 to scripting

Motivation and Context

obs_properties_add_button is deprecated, so the documentation indicates to use obs_properties_add_button2, but that does not exist yet in scripting

How Has This Been Tested?

On windows 11 by running the scripts that are modified

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@sebastian-s-beckmann sebastian-s-beckmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scripting-custom obs_properties_add_button already behaves like libobs' obs_properties_add_button2 (in fact, it uses the libobs v2 function internally, which was originally introduced for exactly that scripting function), so there is no need for this change.
If there is any confusion about this, maybe the documentation needs some kind of update.

@exeldro

exeldro commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Updating the docs might also help, but than we still need to not auto generate scripting functions for obs_properties_add_button2

@WizardCM WizardCM added the kind/bug Categorizes issue or PR as related to a bug. label Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants