obs-scripting: Add obs_properties_add_button2#13584
Open
exeldro wants to merge 1 commit into
Open
Conversation
sebastian-s-beckmann
requested changes
Jun 23, 2026
Member
There was a problem hiding this comment.
The scripting-custom obs_properties_add_button already behaves like libobs' obs_properties_add_button2 (in fact, it uses the libobs v2 function internally, which was originally introduced for exactly that scripting function), so there is no need for this change.
If there is any confusion about this, maybe the documentation needs some kind of update.
Contributor
Author
|
Updating the docs might also help, but than we still need to not auto generate scripting functions for obs_properties_add_button2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add obs_properties_add_button2 to scripting
Motivation and Context
obs_properties_add_button is deprecated, so the documentation indicates to use obs_properties_add_button2, but that does not exist yet in scripting
How Has This Been Tested?
On windows 11 by running the scripts that are modified
Types of changes
Checklist: