libobs: frontend: Update monitoring to bool and add hotkey#13599
Open
Warchamp7 wants to merge 3 commits into
Open
libobs: frontend: Update monitoring to bool and add hotkey#13599Warchamp7 wants to merge 3 commits into
Warchamp7 wants to merge 3 commits into
Conversation
f8b6d86 to
b32eaa6
Compare
b32eaa6 to
80761f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecates
obs_monitoring_typein favor of an on/off boolean toggle. Adds source hotkeys for toggling monitoring on/off on a source.Motivation and Context
#12735 and #13378 introduced easier access to monitoring in the UI, and made it so that monitoring is independent of mute state. This makes the MONITOR_ONLY state effectively obsolete, so this PR removes the enum in favor of an on/off state that represents the new behaviour.
How Has This Been Tested?
Tested that sources handled monitoring correctly, when set via the UI or via websockets using the now deprecated methods. Ensured that the new signal as well as the deprecated one were emitted and handled correctly.
Types of changes
Checklist: