libobs: Fix Wayland segfault on shutdown#13610
Open
joepadmiraal wants to merge 1 commit into
Open
Conversation
The keyboard_listener events can still be triggered after obs_nix_wayland_hotkeys_platform_free has been called, resulting in a segfault inside rebuild_keymap_data. Add a call to wl_keyboard_release to prevent new events from being triggered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The keyboard_listener events can still be triggered after obs_nix_wayland_hotkeys_platform_free has been called, resulting in a segfault inside rebuild_keymap_data. Add a call to wl_keyboard_release to prevent new events from being triggered.
Motivation and Context
I was running OBS 32.1.2 on Ubuntu26.04 and when I closed it the app crashed.
An Ubuntu Apport dialog appeared and after investigating the core dump I found the issue.
How Has This Been Tested?
Since this is a race condition its very hard to reproduce.
I let Claude make a reproduction with a copy of the relevant code from obs-nix-wayland.c and verified with AddressSanitizer.
After the fix I also compiled OBS and ran it couple of times to see if no new shutdown errors appeared.
Types of changes
Checklist: