Skip to content

frontend: Fix volume control resizing and menu warning#13616

Merged
RytoEX merged 2 commits into
obsproject:masterfrom
Warchamp7:vol-control-horiz-widths
Jul 2, 2026
Merged

frontend: Fix volume control resizing and menu warning#13616
RytoEX merged 2 commits into
obsproject:masterfrom
Warchamp7:vol-control-horiz-widths

Conversation

@Warchamp7

@Warchamp7 Warchamp7 commented Jul 2, 2026

Copy link
Copy Markdown
Member

Description

First commit changes the sizeHint and resize behaviour so that the VolumeName widget properly tries to ellide text when it can't fit AND a sizePolicy has been set that allows it to shrink. It also increases the maximum width of the widget in the horizontal mixer layout.

Second commit fixes a warning when showing the audio mixer menu popup.

Motivation and Context

Better use of space for horizontal mixer and better behaviour of the VolumeName widget.

Before After
obs64_dfj20LdNlr.mp4
obs64_ObFgAfmkW4.mp4

Also warnings are bad.

How Has This Been Tested?

👁

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Warchamp7 Warchamp7 added this to the OBS Studio 32.2 milestone Jul 2, 2026
@Warchamp7 Warchamp7 added kind/bug Categorizes issue or PR as related to a bug. kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. area/ui-ux Anything to do with changes or additions to UI/UX elements. labels Jul 2, 2026
@RytoEX RytoEX requested review from PatTheMav and RytoEX July 2, 2026 17:45
@RytoEX RytoEX self-assigned this Jul 2, 2026
Comment thread frontend/components/VolumeName.cpp Outdated
Comment thread frontend/components/VolumeName.cpp Outdated
Warchamp7 added 2 commits July 2, 2026 17:49
Parent the QMenu to the window. Fixes a warning for "QWidgetWindow
must be a top level window."
@RytoEX RytoEX force-pushed the vol-control-horiz-widths branch from 70b518a to a99873f Compare July 2, 2026 21:50
@RytoEX RytoEX merged commit 30d3b89 into obsproject:master Jul 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui-ux Anything to do with changes or additions to UI/UX elements. kind/bug Categorizes issue or PR as related to a bug. kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants