frontend: Fix volume control resizing and menu warning#13616
Merged
Conversation
RytoEX
requested changes
Jul 2, 2026
PatTheMav
approved these changes
Jul 2, 2026
Parent the QMenu to the window. Fixes a warning for "QWidgetWindow must be a top level window."
70b518a to
a99873f
Compare
RytoEX
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First commit changes the sizeHint and resize behaviour so that the VolumeName widget properly tries to ellide text when it can't fit AND a sizePolicy has been set that allows it to shrink. It also increases the maximum width of the widget in the horizontal mixer layout.
Second commit fixes a warning when showing the audio mixer menu popup.
Motivation and Context
Better use of space for horizontal mixer and better behaviour of the VolumeName widget.
obs64_dfj20LdNlr.mp4
obs64_ObFgAfmkW4.mp4
Also warnings are bad.
How Has This Been Tested?
👁
Types of changes
Checklist: