Remove extra copy_module_type from pmty_with migration from 504 to 503#644
Merged
Merged
Conversation
Signed-off-by: Stefan Muenzel <source@s.muenzel.net>
smuenzel
force-pushed
the
remove-duplicate-copy
branch
from
cde8606 to
b72234b
Compare
smuenzel
requested review from
NathanReb,
ceastlund,
panglesd and
patricoferris
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
astlib/migrate_504_503.ml, when migratingPmty_with, the module type is copied twice.This can be especially bad with many nested
withconstraints, such as https://github.com/janestreet/base/blob/259754a4a8601a1c59a9dcf2baf008e2a90d54fd/src/import0.ml#L5-L42, seemingly leading to a double copying at every constraint.This error was found with claude code.