Bugfix: Remove ament_target_dependencies calls from CMakeLists.txt files#53
Open
gaerisen wants to merge 1 commit into
Open
Bugfix: Remove ament_target_dependencies calls from CMakeLists.txt files#53gaerisen wants to merge 1 commit into
gaerisen wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ament_target_dependencies()has been deprecated since Kilted, and has been removed from Lyrical entirely, causing builds to fail. Remove allament_target_dependencies()calls and usetarget_link_libraries()with modern CMake target specifiers instead.For the curious, this thread discusses why the change was made and why
target_link_librariesis functionally equivalent.I couldn't find any explicit mention of Lyrical support (README just indicates '>=Humble'), but this has been my only problem so far.