add overflow checks for IPC handle size#1579
Merged
Merged
Conversation
bratpiorka
force-pushed
the
rrudnick_fix_IPC
branch
from
7914d61 to
e64a81e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if: ${{matrix.shared_library == 'ON' && matrix.compiler.cxx == 'cl'}} | ||
| run: ${{github.workspace}}/.github/scripts/check_dll_flags.ps1 ${{env.BUILD_RELEASE_DIR}}/bin/Release/umf.dll | ||
| run: | | ||
| if (Test-Path "${{env.BUILD_RELEASE_DIR}}/bin/Release/umf.dll") { |
| run: ${{github.workspace}}/.github/scripts/check_dll_flags.ps1 ${{env.BUILD_RELEASE_DIR}}/bin/Release/umf.dll | ||
| run: | | ||
| if (Test-Path "${{env.BUILD_RELEASE_DIR}}/bin/Release/umf.dll") { | ||
| $dll_path = "${{env.BUILD_RELEASE_DIR}}/bin/Release/umf.dll" |
| if (Test-Path "${{env.BUILD_RELEASE_DIR}}/bin/Release/umf.dll") { | ||
| $dll_path = "${{env.BUILD_RELEASE_DIR}}/bin/Release/umf.dll" | ||
| } else { | ||
| $dll_path = "${{env.BUILD_RELEASE_DIR}}/bin/umf.dll" |
| - name: check /DEPENDENTLOADFLAG in umf.dll | ||
| run: ${{github.workspace}}/.github/scripts/check_dll_flags.ps1 ${{env.BUILD_DIR}}/bin/${{matrix.build_type}}/umf.dll | ||
| run: | | ||
| if (Test-Path "${{env.BUILD_DIR}}/bin/${{matrix.build_type}}/umf.dll") { |
| run: ${{github.workspace}}/.github/scripts/check_dll_flags.ps1 ${{env.BUILD_DIR}}/bin/${{matrix.build_type}}/umf.dll | ||
| run: | | ||
| if (Test-Path "${{env.BUILD_DIR}}/bin/${{matrix.build_type}}/umf.dll") { | ||
| $dll_path = "${{env.BUILD_DIR}}/bin/${{matrix.build_type}}/umf.dll" |
| if (Test-Path "${{env.BUILD_DIR}}/bin/${{matrix.build_type}}/umf.dll") { | ||
| $dll_path = "${{env.BUILD_DIR}}/bin/${{matrix.build_type}}/umf.dll" | ||
| } else { | ||
| $dll_path = "${{env.BUILD_DIR}}/bin/umf.dll" |
bratpiorka
force-pushed
the
rrudnick_fix_IPC
branch
from
566b939 to
5c86bb8
Compare
| if: ${{matrix.shared_library == 'ON' && matrix.compiler.cxx == 'cl'}} | ||
| run: ${{github.workspace}}/.github/scripts/check_dll_flags.ps1 ${{env.BUILD_RELEASE_DIR}}/src/proxy_lib/Release/umf_proxy.dll | ||
| run: | | ||
| if (Test-Path "${{env.BUILD_RELEASE_DIR}}/src/proxy_lib/Release/umf_proxy.dll") { |
| run: ${{github.workspace}}/.github/scripts/check_dll_flags.ps1 ${{env.BUILD_RELEASE_DIR}}/src/proxy_lib/Release/umf_proxy.dll | ||
| run: | | ||
| if (Test-Path "${{env.BUILD_RELEASE_DIR}}/src/proxy_lib/Release/umf_proxy.dll") { | ||
| $dll_path = "${{env.BUILD_RELEASE_DIR}}/src/proxy_lib/Release/umf_proxy.dll" |
PatKamin
reviewed
Jun 11, 2026
| } | ||
|
|
||
| umf_result_t ext_get_ipc_handle_size(size_t *size) noexcept { | ||
| *size = std::numeric_limits<size_t>::max(); |
Contributor
There was a problem hiding this comment.
Lower value of std::numeric_limits<size_t>::max() - sizeof(ipc_cache_value_t) + 1 should satisfy the tests. Please, check that
| if: ${{matrix.shared_library == 'ON' && matrix.compiler.cxx == 'cl'}} | ||
| run: ${{github.workspace}}/.github/scripts/check_dll_flags.ps1 ${{env.BUILD_RELEASE_DIR}}/src/proxy_lib/Release/umf_proxy.dll | ||
| run: | | ||
| Get-ChildItem -Path "${{env.BUILD_RELEASE_DIR}}" -Recurse |
bratpiorka
force-pushed
the
rrudnick_fix_IPC
branch
from
f1f1b96 to
9979001
Compare
| if (Test-Path "${{env.BUILD_RELEASE_DIR}}/src/proxy_lib/Release/umf_proxy.dll") { | ||
| $dll_path = "${{env.BUILD_RELEASE_DIR}}/src/proxy_lib/Release/umf_proxy.dll" | ||
| } else { | ||
| $dll_path = "${{env.BUILD_RELEASE_DIR}}/src/proxy_lib/umf_proxy.dll" |
bratpiorka
force-pushed
the
rrudnick_fix_IPC
branch
4 times, most recently
from
a696d86 to
41e722f
Compare
PatKamin
approved these changes
Jun 12, 2026
Collaborator
|
zizmor fixes TBD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add overflow checks for IPC handle size with tests