Remove causal prefixes when using buses implemented as expandable connectors.#1499
Open
qlambert-pro wants to merge 1 commit into
Open
Remove causal prefixes when using buses implemented as expandable connectors.#1499qlambert-pro wants to merge 1 commit into
qlambert-pro wants to merge 1 commit into
Conversation
…nectors. `expandable connector`s have an inference mechanism to sort out the causality of signals contained in them. Adding a causal prefix makes it invalid to connect to the bus present in `IDEAS.BoundaryConditions.SimInfoManager`, for instance, as this one doesn't have such a prefix. This specific issue was originally discovered in `IDEAS.BoundaryConditions.SolarIrradiation.RadSolData` at line 176.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section 9.3 of the specs says:
expandable connectors have an inference mechanism to sort out the causality of signals contained in them. Adding a causal prefix makes it invalid to connect to the bus present inIDEAS.BoundaryConditions.SimInfoManager, for instance, as this one doesn't have such a prefix.This specific issue was originally discovered in
IDEAS.BoundaryConditions.SolarIrradiation.RadSolDataat line 176.This commit removes all prefixes use for instances of
IDEAS.Buildings.Components.Interfaces.WeaBus, an alternative to this PR would be to carefully study how the class is used and to add the appropriate causal prefixes where they are needed.I can't find a way for this commit to introduce regressions, but somehow my gut is still worried that it might, I just figured I should disclose it, as I wasn't able to fully test the outcome of the change.