feat: Use global propagator as default#2345
Open
thompson-tomo wants to merge 2 commits into
Open
Conversation
thompson-tomo
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
hannahramadan,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
thompson-tomo
changed the title
thompson-tomo
changed the title
thompson-tomo
force-pushed
the
feat/global_propagator
branch
from
d020446 to
25e8d7b
Compare
Contributor
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2236
The trilogy instrumentation now uses the global propagator by default for both dup & stable which brings it in closer alignment with the spec. The global propagator can be overridden with sql commenter by setting
use_sqlcommentertotrue. See https://opentelemetry.io/docs/specs/semconv/db/database-spans/#sql-commenter for details of where this behaviour is defined.Coverage report before change:
Coverage report after change:
Which confirms the new lines are covered and no coverage has been lost due to change.