Skip to content

feat: only emit span events by default on old semconv#2347

Open
thompson-tomo wants to merge 1 commit into
open-telemetry:mainfrom
thompson-tomo:disable_spanEvents
Open

feat: only emit span events by default on old semconv#2347
thompson-tomo wants to merge 1 commit into
open-telemetry:mainfrom
thompson-tomo:disable_spanEvents

Conversation

@thompson-tomo

@thompson-tomo thompson-tomo commented May 17, 2026

Copy link
Copy Markdown
Contributor

This switches span events to only be enabled by default on old semconv due to span events undergoing deprecation, the event name is not accurate & the definition is not stable.

Coverage report before change:

Line Coverage: 98.31% (233 / 237)

Coverage report after change:

Line Coverage: 98.32% (234 / 238)

@hannahramadan

Copy link
Copy Markdown
Member

Hi @thompson-tomo! I was reading the blog post about this and it seems like the guidance is to move the signal to logs, not drop it, and to keep existing stable majors behaviorally compatible for now. If I remember correctly, the Logs API isn't quite ready for this change. I'm worried this is a step too soon, but I could be missing something. What do you think?

@thompson-tomo

thompson-tomo commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Yes the intention would be to add log events however this doesn't drop them but instead only emits them by default on the old conventions hence users need to optin to keep them when they switch to stable.

existing stable majors behaviorally compatible for now.

Doesn't apply here as we don't have a major release which is what I want to get us to a position to release.

In regards to if the logs api is ready I think it might be functionally ready after @kaylareopelle recent pr to add event names. That being said, it's not a stable package. So more work would be needed there.

@thompson-tomo thompson-tomo requested review from a team as code owners May 26, 2026 02:56
@github-actions

Copy link
Copy Markdown
Contributor

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions Bot added the stale Marks an issue/PR stale label Jun 26, 2026
@thompson-tomo thompson-tomo removed the stale Marks an issue/PR stale label Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants