feat: only emit span events by default on old semconv#2347
feat: only emit span events by default on old semconv#2347thompson-tomo wants to merge 1 commit into
Conversation
|
Hi @thompson-tomo! I was reading the blog post about this and it seems like the guidance is to move the signal to logs, not drop it, and to keep existing stable majors behaviorally compatible for now. If I remember correctly, the Logs API isn't quite ready for this change. I'm worried this is a step too soon, but I could be missing something. What do you think? |
|
Yes the intention would be to add log events however this doesn't drop them but instead only emits them by default on the old conventions hence users need to optin to keep them when they switch to stable.
Doesn't apply here as we don't have a major release which is what I want to get us to a position to release. In regards to if the logs api is ready I think it might be functionally ready after @kaylareopelle recent pr to add event names. That being said, it's not a stable package. So more work would be needed there. |
bf9878d to
d1bd2f4
Compare
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
This switches span events to only be enabled by default on old semconv due to span events undergoing deprecation, the event name is not accurate & the definition is not stable.
Coverage report before change:
Coverage report after change: