refactor: integrate httpx instrumentation with the tracing plugin#2359
Open
HoneyryderChuck wants to merge 1 commit into
Open
refactor: integrate httpx instrumentation with the tracing plugin#2359HoneyryderChuck wants to merge 1 commit into
HoneyryderChuck wants to merge 1 commit into
Conversation
HoneyryderChuck
force-pushed
the
httpx-tracing-plugin-integration
branch
3 times, most recently
from
4f8e910 to
15f6070
Compare
HoneyryderChuck
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
hannahramadan,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
HoneyryderChuck
force-pushed
the
httpx-tracing-plugin-integration
branch
from
15f6070 to
131cd36
Compare
HoneyryderChuck
changed the title
HoneyryderChuck
force-pushed
the
httpx-tracing-plugin-integration
branch
7 times, most recently
from
9ce0a0b to
35e59a2
Compare
thompson-tomo
previously requested changes
May 21, 2026
thompson-tomo
left a comment
thompson-tomo
left a comment
Contributor
There was a problem hiding this comment.
Can you ensure that the tests are passing to avoid regressions.
HoneyryderChuck
force-pushed
the
httpx-tracing-plugin-integration
branch
2 times, most recently
from
74de494 to
b153d3d
Compare
Contributor
Author
|
@thompson-tomo tests are passing now |
thompson-tomo
dismissed
their stale review
Tests are now passing without changes.
Contributor
Author
|
@thompson-tomo any updates? |
Contributor
There was a problem hiding this comment.
These changes need to be replicated to stable & dup.
Contributor
Author
There was a problem hiding this comment.
they were already. unless I misunderstood, can you be clear about what exactly needs to be replicated?
`httpx` v1.7.4 ships with the `:tracing` plugin, which ships the whole boilerplate around tracing when a request starts and finishes, thereby enabling the removal of most of the current code. It has been since then the foundation for the `:datadog` integration too.
HoneyryderChuck
force-pushed
the
httpx-tracing-plugin-integration
branch
from
b153d3d to
57d4d76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpxv1.7.4 ships with the:tracingplugin, which ships the whole boilerplate around tracing when a request starts and finishes, thereby enabling the removal of most of the current code.It has been since then the foundation for the
:datadogintegration too.