fix: ensure valid json message attribute value#2428
Open
thompson-tomo wants to merge 2 commits into
Open
Conversation
thompson-tomo
requested review from
a team,
dazuma,
hannahramadan,
kaylareopelle,
robbkidd,
simi and
xuan-cao-swi
as code owners
scbjans
reviewed
Jul 3, 2026
| when Array | ||
| value.all? { |v| utf8_clean?(v) } | ||
| else | ||
| true |
Contributor
There was a problem hiding this comment.
Shouldn't we set this to false, and drop anything which is not a String?
Contributor
Author
There was a problem hiding this comment.
Hmm, in this scenario, yes it can probs be simplified as the additional scenarios were from when i was doing it in a different location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the message attribute is consistently encoded across jruby and ruby.
This is achieved by adding a value check for the message value which is automatically done on ruby but not jruby.