fix: do not report disabled instrumentations as failures#2216
Open
0robustus1 wants to merge 2 commits into
Open
fix: do not report disabled instrumentations as failures#22160robustus1 wants to merge 2 commits into
0robustus1 wants to merge 2 commits into
Conversation
It can be very confusing to see a "Instrumentation: OpenTelemetry::Instrumentation::Sinatra failed to install" log line when that instrumentation is in fact just disabled (via `enabled: false`) or 'OTEL_RUBY_INSTRUMENTATION_SINATRA_ENABLED=false'. This instead reports it as a not-enabled instrumentation.
Contributor
|
Thanks for bringing this up. Since you're already working on this, could you also include a compatibility check (e.g., |
Author
|
@xuan-cao-swi good point. Added it. |
Author
|
Test failure seems to report on other PRs as well: So it might be broken on main? |
mwear
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be very confusing to see a
Instrumentation: OpenTelemetry::Instrumentation::Sinatra failed to installlog line when that instrumentation is in fact just disabled (viaenabled: false) orOTEL_RUBY_INSTRUMENTATION_SINATRA_ENABLED=false. This instead reports it as a not-enabled instrumentation.