Feature/create api marketplace metrics#37
Conversation
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
1 similar comment
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
…can be generated in the client.
jordivx
force-pushed
the
feature/create-api-marketplace-metrics
branch
from
302e7ed to
a069870
Compare
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
jorge-romero
left a comment
jorge-romero
left a comment
There was a problem hiding this comment.
- Please move your version to v0.0.4, as we are delivering the v0.0.3 now :-)
- Remove autogenerated by OpenAPI classes like MarketplaceMetricsApi.java and the model (if it comes with the next PR I could assume to have it. It includes the API and the service
- We are missing controller tests.
…marketplace-metrics
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
1 similar comment
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
Co-authored-by: Vila,Jordi (IT EDP) <jordi.vila@boehringer-ingelheim.com>
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
…arketplace external service
|
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
jorge-romero
left a comment
jorge-romero
left a comment
There was a problem hiding this comment.
Please review my comments
|
|
||
| @Override | ||
| public ResponseEntity<MarketplaceCatalogItemsMetrics> getMarketplaceCatalogItemsMetrics() { | ||
| MarketplaceCatalogItemsMetrics catalogItemsMetrics = marketplaceMetricsFacade.getMarketplaceCatalogItemsMetrics(); |
There was a problem hiding this comment.
marketplaceMetricsFacade.getMarketplaceCatalogItemsMetrics() return an empty list or throws an exception, so the not found return is never executed.
| title: An item title | ||
| shortDescription: Example description | ||
| date: "2021-07-01T00:00:00Z" | ||
| pagination: |
There was a problem hiding this comment.
The pagination we agree that was not needed why it is returned?
| -- changeset ods:010-seed-marketplace-metrics-api-definitions | ||
| -- Description: Seed API definitions for Marketplace Metrics API. | ||
| -- ============================================================================ | ||
| INSERT INTO api_definitions (api_id, name, base_path, version, auth_types, is_public, enabled) |
There was a problem hiding this comment.
Review which will be the endpoint, as if it the marketplace metrics, the semantic of nesting under projects is not clear to me.
As you are adding an api for get all the catalog-items, and other to get all the components for all the projects.
The semantic of the projects api is managing the projects, and projects/xxx/components manage the components.
It this is for metrics it should be in a different path the retrieval of catalog-items at least
| "404": | ||
| $ref: "#/components/responses/NotFoundResponse" | ||
| "500": | ||
| $ref: "#/components/responses/InternalErrorResponse" |
There was a problem hiding this comment.
the 502 is returned too
| "404": | ||
| $ref: "#/components/responses/NotFoundResponse" | ||
| "500": | ||
| $ref: "#/components/responses/InternalErrorResponse" |
4 participants
No description provided.