8385815: [CRaC] Fix aarch64 failing testcases

[jankratochvil]

test/jdk/jdk/crac/CPUFeatures/SimpleCPUFeaturesTest.java
test/jdk/jdk/crac/engine/CheckCPUFeaturesTest.java

It needs some updates for the new CPU Features support.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8385815: [CRaC] Fix aarch64 failing testcases (Bug - P4)

Reviewers

• Timofei Pushkin (@TimPushkin - Committer) ⚠️ Review applies to 7a7e742e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/321/head:pull/321
$ git checkout pull/321

Update a local copy of the PR:
$ git checkout pull/321
$ git pull https://git.openjdk.org/crac.git pull/321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 321

View PR using the GUI difftool:
$ git pr show -t 321

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/321.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8385815: [CRaC] Fix aarch64 failing testcases

Reviewed-by: tpushkin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the crac branch:

• 834e730: 8388144: [CRaC] CRIU fails to restore jdk/crac/SecureRandom/InterlockTest

Please see this link for an up-to-date comparison between the source branch of this pull request and the crac branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the crac branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 29: Full - Incremental (10f92339)
• 28: Full - Incremental (7a7e742e)
• 27: Full - Incremental (31f02982)
• 26: Full - Incremental (96e0bab0)
• 25: Full - Incremental (fb2b917c)
• 24: Full - Incremental (bacb940d)
• 23: Full - Incremental (9234bbf0)
• 22: Full - Incremental (d2d6b560)
• 21: Full - Incremental (6bc10e4a)
• 20: Full - Incremental (9ecabed0)
• 19: Full - Incremental (e5c19cf4)
• 18: Full - Incremental (5f99e037)
• 17: Full - Incremental (9e37a402)
• 16: Full - Incremental (4d78c6c6)
• 15: Full - Incremental (e56848a3)
• 14: Full - Incremental (dc6d1cbb)
• 13: Full (e8da63a0)
• 12: Full - Incremental (fcfca738)
• 11: Full - Incremental (6745562a)
• 10: Full - Incremental (6566d0af)
• 09: Full - Incremental (2972e2e2)
• 08: Full - Incremental (b3b86640)
• 07: Full - Incremental (bcd03d7f)
• 06: Full (b59fff86)
• 05: Full - Incremental (e485a964)
• 04: Full - Incremental (3fee099a)
• 03: Full - Incremental (2d75c5d4)
• 02: Full - Incremental (dd9a56c3)
• 01: Full - Incremental (6c349cde)
• 00: Full (104cdff9)

[jankratochvil]

The failed CI is a false positive:

• jdk/crac/ContainerOOMETest

[jankratochvil]

With upstream CRIU it somehow does not work now:

+ bin/java -XX:CRaCCheckpointTo=cr -XX:+ShowCPUFeatures -XX:CRaCEngine=criuengine -XX:CPUFeatures=0x21461805ddfbf7,0xfcc0000000000000 CPUFeaturesAWS
This machine's CPU features are: -XX:CPUFeatures=0xe14e1b9dfdfbff,0xfcc0000000000000
CPU features being used are: -XX:CPUFeatures=0x21461805ddfbf7,0xfcc0000000000000
Original environment variable: GLIBC_TUNABLES=glibc.pthread.rseq=0
Re-exec of java with new environment variable: GLIBC_TUNABLES=glibc.pthread.rseq=0:glibc.cpu.hwcaps=,-ERMS,-AVX512F,-AVX512CD,-AVX512BW,-AVX512DQ,-AVX512VL
This machine's CPU features are: -XX:CPUFeatures=0xe14e1b9dfdfbff,0xfcc0000000000000
CPU features being used are: -XX:CPUFeatures=0x21461805ddfbf7,0xfcc0000000000000
CPUFeaturesCheck 0
CPUFeaturesCheck 1
+ set +e
+ bin/jcmd CPUFeaturesAWS JDK.checkpoint
CPUFeaturesCheck 2
CPUFeaturesCheck 3
CPUFeaturesCheck 4
CPUFeaturesCheck 5
CPUFeaturesCheck 6
CPUFeaturesCheck 7
Could not find any processes matching : 'CPUFeaturesAWS'
+ wait 2084
CPUFeaturesCheck 8
CPUFeaturesCheck 9
...
CPUFeaturesCheck 367
CPUFeaturesCheck 368
CPUFeaturesCheck 369
...

[jankratochvil]

windows-aarch64 is a false positive failure:

• https://github.com/jankratochvil/crac/actions/runs/29212730408/job/86703144212#step:3:266

error: msys: signature from "Christoph Reiter (MSYS2 development key) <reiter.christoph@gmail.com>" is unknown trust

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version e5c19cf) is now ready to be sponsored by a Committer.

[jankratochvil]

/integrate

[openjdk]

Going to push as commit 49b2867.
Since your change was applied there has been 1 commit pushed to the crac branch:

• 834e730: 8388144: [CRaC] CRIU fails to restore jdk/crac/SecureRandom/InterlockTest

Your commit was automatically rebased without conflicts.

[openjdk]

@jankratochvil Pushed as commit 49b2867.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.