feat(config): gate custom currency catalog use#4752
Draft
turip wants to merge 2 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
credits.customCurrency, enabled only when both it andcredits.enabledare trueconfig.example.yamlWhy
PR #4738 adds product catalog persistence for custom currencies. This follow-up keeps that experimental storage path disabled by default and makes deployments opt in explicitly.
Impact
Existing resources remain readable, archivable, and deletable when the switch is off. The service checks both a custom plan/add-on currency and custom currencies used by individual rate cards.
Validation
go test ./app/config ./openmeter/productcatalogPOSTGRES_HOST=127.0.0.1 go test -tags=dynamic ./app/config ./app/common ./openmeter/productcatalog/... ./test/productcataloggo vet -tags=dynamic ./app/config ./app/common ./openmeter/productcatalog/... ./test/productcataloggo test -tags=dynamic ./quickstartgo test -C e2e -run '^$' ./...go test -tags=dynamic -run '^$' ./...make lint-go-faststill reports existing generated-code findings outside this change.Greptile Summary
This PR makes custom-currency catalog storage an explicit opt-in feature. The main changes are:
credits.customCurrencysetting.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "style: separate catalog validation check..." | Re-trigger Greptile
Context used: