Skip to content

chore: validate pointer receiver#4770

Draft
turip wants to merge 2 commits into
mainfrom
chore/validate-pointer-receiver
Draft

chore: validate pointer receiver#4770
turip wants to merge 2 commits into
mainfrom
chore/validate-pointer-receiver

Conversation

@turip

@turip turip commented Jul 21, 2026

Copy link
Copy Markdown
Member

Overview

Fixes #(issue)

Notes for reviewer

Greptile Summary

This PR updates FiatCurrency to support value-based method calls. The main changes are:

  • Converts the primary FiatCurrency methods from pointer receivers to value receivers.
  • Updates Validate while preserving uninitialized-definition handling.
  • Adds tests for pointer and dereferenced-value validation calls.

Confidence Score: 5/5

This looks safe to merge.

  • The updated receiver methods continue to satisfy the existing interfaces.
  • Validation still returns an error when the currency definition is missing.
  • No blocking issues were found in the changed code.

Important Files Changed

Filename Overview
pkg/currencyx/currency.go Changes the main FiatCurrency methods to value receivers while retaining validation for a missing definition.
pkg/currencyx/currency_test.go Adds receiver-focused validation coverage for pointer and dereferenced-value calls.

Reviews (2): Last reviewed commit: "feat: xxx" | Re-trigger Greptile

Context used:

  • Context used - CLAUDE.md (source)
  • Context used - AGENTS.md (source)

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dae5c761-341f-40ab-aff6-27ff1885b44c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/validate-pointer-receiver

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@turip
turip force-pushed the chore/validate-pointer-receiver branch from e9b268f to fb51793 Compare July 21, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant